chore: fix releasing script#969
Merged
google-oss-prow[bot] merged 6 commits intokubeflow:notebooks-v1from Mar 18, 2026
Merged
Conversation
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
google-oss-prow
bot
added
area/controller
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
google-oss-prow
bot
added
area/ci
andyatmiami
approved these changes
Mar 18, 2026
Contributor
andyatmiami
left a comment
andyatmiami
left a comment
There was a problem hiding this comment.
/lgtm
- great alignment across
Makefilenow - excellent catch on the
kubeflow/kubeflowreferences... i'm surprised we let this glaring oversight fester here - but thanks for update
Contributor
|
/ok-to-test |
Member
Author
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-project-automation
bot
moved this from Needs Triage
to Done
in Kubeflow Notebooks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the releasing script so that it actually updates all the image tags, namely the example notebook-servers under
components/crud-web-apps/jupyter/manifests/base/configs/spawner_ui_config.yaml.It also fixes a critical typo which would have caused the images to still be pulled from
ghcr.io/kubeflow/kubeflow/xxxxrather thanghcr.io/kubeflow/notebooks/xxxx(for the non notebook-servers images, as we left those onghcr.io/kubeflow/kubeflow/notebook-servers/xxxxeven though they now push from this repo.Other changes:
go mod downloadsofgithub.com/hashicorpin Dockerfiles